-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
try to fix LTS prerelease workflow #10429
base: master
Are you sure you want to change the base?
Conversation
651a604
to
8e9920e
Compare
Untestable until backported. ☹ |
@mergify backport 3.12 |
🟠 Waiting for conditions to match
|
8e9920e
to
2817c83
Compare
73dd5b1
to
20e3ffd
Compare
Well, not quite true, I pushed the conditional down into the actually-make-the-release step so I can verify the rest (and already found one bug) and in particular check why it's skipping (which it should in the PRs and on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, let's see if this works fine.
Per my previous comment, it won't; I'm trying to determine why with this update, along with trying a few things that I'm now pretty sure won't work. The main point, though, is to get some debug output about why it's not running when it's supposed to (currently it's always skipped even when merging to 3.12 branch). Hopefully when this lands in 3.12 it'll tell me enough that I can submit a follow-on that does make it work. |
20e3ffd
to
8535d91
Compare
I'm not sure if the LTS prerelease should include the LTS designation in the filenames. I'm currently (once I get the code working) including it, but it could be argued that it shouldn't be there. |
It's being skipped, not failing to fire, implying the wrong ref? This subsumes haskell#10415.
8535d91
to
657d686
Compare
It's being skipped, not failing to fire, implying the wrong ref? This subsumes #10415.
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR: